Closed FlyingDR closed 6 years ago
Merging #23 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #23 +/- ##
=======================================
Coverage 100% 100%
Complexity 45 45
=======================================
Files 4 4
Lines 139 139
=======================================
Hits 139 139
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 08473ec...77882fe. Read the comment docs.
@gbprod Into commit ba542e5 I've removed Symfony 3.0 from tests matrix and replaced it with 3.4 LTS. Since this is partially out of scope of this pull request - here are reasons for this change:
There is at least 2 reasons for tests to be broken:
Hope these reasons are good enough to approve this change.
Thanks for you're contribution, I'll take some times to review before merge !
Seems that you've not updated the CHANGELOG.md
file. Can you add the changes description ?
Thanks @FlyingDR for this contribution, I really appreciate :)
This pull request fixes issue #22 with web toolbar integration and adds tests for proper integration of services of the bundle into Symfony.