Doc review for issue 485

[thatdocslady]

Heya,

I hope I didn't mess anything up in the files or in Git, first time trying this!

A few questions/notes about the content:

• startup vs. pre-flight check - You used "startup" in almost all the doc strings, but the file itself is called pre-flight. Both terms are ok but we need to be consistent. For now I standardzied on startup in the docs but if you want to change everything to pre-flight we can do that, we just need to decide which one to use :)

• check vs. test - In most cases you used "check" but when you talked about the network checks you used "tests". Since they're all a part of the same sequence of checks/tests, we should be consistent in the term as well. Again, both terms are ok grammatically and stylistically, but we should stick with one term. For now I changed "tests" to "checks" because "checks" was used more often, and it'll also help to search/replace later if we want to change it.

• I changed the numbered list to bulleted list in the force start commands, because they're not actually supposed to be done in sequence, but rather users should choose one based on their OS.

• Why is the Hyper-V doc string different from the others? The others use "installed" and the Hyper-V uses "configured"/"set". Also, why do we not refer users to the docs for Hyper-V?

• General notes: no need to write "please", we don't have to be that nice in docs ;) also, we should avoid using "we", and refer to what Minishift does or any component, since we are not personally there when the users use our software :)

[gbraad]

@thatdocslady I did not repeatedly want to use the same words, as this sounds monotone. But sure, if you think it is OK, I will use a single term.

But now, why Hyper-V uses a different term? Just like VirtualBox, we do not install Hyper-V as a driver plugin. We ONLY check if the virtual switch is selected, ... but yes, maybe I should refer to this document for this.

[gbraad]

You probably rebased onto master? Anyways, this can be resolved...

$ git rebase -i HEAD~4

and use d (drop) for changes aa6de92 (Typo in service command) and for 2443999 (Return error for SSH close)

This results in: https://github.com/gbraad/minishift/commit/ad2ab12a02fed904c3d9938b88ccd8070cd9e32c

[gbraad]

updated minishift#1162

[gbraad]

Merged and rebased