Added comments on failure

gbrammer / grizli

Grizli: The "Grism redshift and line" analysis software

MIT License

64 stars 50 forks source link

Closed TheSkyentist closed 4 months ago

TheSkyentist commented 4 months ago

Added logging messages if a reference image or segmentation image can't be found. In reference to #190.

gbrammer commented 4 months ago

Looks fine but there is a bug in the implementation.

TheSkyentist commented 4 months ago

Added a patch for the bug (I think?). If this was not the bug you meant to fix, can you clarify which bug?

gbrammer commented 4 months ago

Yes, that's it. I had started a code review and highlighted the lines, but it seems like I didn't submit the review at the end.

Looks good now.