Migrate to Rack v1.0

[dogonthehorizon]

Hey @gbrandt1, are you at all in the process of updating this plugin to to the v1 api? I've started doing so in a fork here: https://github.com/dogonthehorizon/southpole-vcvrack/tree/v1

Happy to submit a PR once it's in a working state :)

[Torinbob]

I just popped in to see if Southpole was being migrated to V1. Glad to see it looks like these great plugins might get updated one way or another!

[dogonthehorizon]

@Torinbob if you have previous experience or a desire to learn C++ I'd be happy to have the help :) Currently middling through compile errors after updating a few things. Otherwise no worries, I'll keep chugging along!

[Torinbob]

I'm afraid I have no experience of C++ at all nor the time to learn it right now (but at some point I'd like to!)

Are you a member of the VCV Rack Plugin Developers group of Facebook? It would be a good place to ask for some help.

https://www.facebook.com/groups/2035785263299933/

[dogonthehorizon]

No worries! I'm not a member of the FB group, but have joined the VCV Rack Discourse community :) thanks!

[gbrandt1]

hi @dogonthehorizon et al.! thanks for the help and offer. i will definitely consider a pull request once your fork goes forward! we can discuss any roadblocks you might hit in this thread.

[dogonthehorizon]

The v1 branch now compiles but immediately crashes VCVRack when going into the module add menu, likely because I haven't addressed migration step 1.9 :woman_shrugging:

Haven't started whittling down deprecation warnings.

@gbrandt1 I wasn't sure what to put for your information in plugin.json, would you like me to leave it as is and you'll fix it post-merge, or shall I fill in your details now?

[dogonthehorizon]

Aaaand as of this commit I have it building and not segfaulting in the UI. In my confusion I started porting draw actions to the new api, which we'll need to do eventually but wasn't strictly necessary for now.

I lightly tested using the SNS module to generate some beeps in a VCA but haven't done much beyond that.

Next step, whittle down deprecation warnings! Feels like the home stretch :)

[gbrandt1]

@dogonthehorizon i can do the finishing touches likes update the json etc. i plan to go through everything for a clean-up anyways and to decide where to implement polyphony, side-panels etc. just send the pull request whenever you get fed up and i'll take over. your work is much appreciated!

[Torinbob]

Can I ask if you think Snake will still work in V1 please

[dogonthehorizon]

@Torinbob I don't see why not :woman_shrugging:

@gbrandt1 sounds good, I'll make a PR with what I have this evening. I've gotten through most of the phase 2 refactors, just working out a few last compile errors!

[dogonthehorizon]

PR created here: https://github.com/gbrandt1/southpole-vcvrack/pull/37

I figure since @gbrandt1 mentioned wanting to implement some v1 features we'd close this issue when it's all said and done, rather than when the PR is merged :)

[gbrandt1]

@dogonthehorizon i agree it's better to continue in a v1 branch, i've created it, could you change the base branch of your PR please? i don't see how i can accept it to another branch than master from my side.

i also agree we should keep this issue open until 1.0 has been released (and maybe even until 1.0.1 with bug fixes has been released ;-) )

[veryfungi]

thank you guys for working on these modules! I used a lot of them all the time and miss them very much. Thanks again.

[gilbertohasnofb]

Any news about a v1.0 release?

[netboy3]

I've just posted a new Pull-Request for finalizing the V1.0 release. Merging my pull-request, together with PR#41, PR#42, PR#43 and PR#44 should get us to a release ready v1 branch. @gbrandt1, I believe we are really close to the finish line. I've tested all the modules extensively and they all seem to function well. I'll be posting build binaries of all the above merged pull-requests shortly so we can have a larger group testing. @gbrandt1, thank you for a great plugin set and @dogonthehorizon, thank you for your hard work on migrating. The Rack community would love to see this wonderful set back on the official plugin library.

[netboy3]

Following are builds that, I believe, are V1 ready. One thing to note, this build fixes an issue that was introduced during the initial migration which broke patch compatibility. This build is again compatible with the saved 0.6 patches. Unfortunately this means that if you have a patch you saved lately with the buggy version, it will not load. You can fix such broken patch files by opening the .vcv file with a text editor and replacing every instance of "southpole" with "Southpole". I would appreciate if folks can test those out and leave feedback on this thread of any issues they discover.

Linux: Southpole-1.0.0-lin.zip Mac: Southpole-1.0.0-mac.zip Windows: Southpole-1.0.0-win.zip

[SteveRussell33]

This is my local build which includes both eggix's fixes from https://github.com/gbrandt1/southpole-vcvrack/pull/42, https://github.com/gbrandt1/southpole-vcvrack/pull/43, https://github.com/gbrandt1/southpole-vcvrack/pull/44 and netboy3's cleanup from https://github.com/gbrandt1/southpole-vcvrack/pull/46 as well as my own additions from https://github.com/gbrandt1/southpole-vcvrack/pull/47.

Windows only - sorry about that. Southpole-1.0.0.2019.10.20-win.zip Updated to include https://github.com/gbrandt1/southpole-vcvrack/pull/47/commits/d7f57fdb75c5aa6c0a6aabad7a1da761f4e8ff81 - please use this test .vcv patch: Splash envelope fix test.zip (Requires Circlefade Random2 module)

[netboy3]

I've just posted a new pull request for Southpole-parasites which is the southpole Splash and Smoke using the modified parasites firmware. I will follow up with platform builds so the community can test the port out.

[netboy3]

Following are builds for Southpole-parasites that, I believe, are V1 ready. I would appreciate if folks can test those out and leave feedback on this thread of any issues they discover.

Linux: Southpole-parasites-1.0.0-lin.zip Mac: Southpole-parasites-1.0.0-mac.zip Windows: Southpole-parasites-1.0.0-win.zip

[veryfungi]

Hello netboy3, I downloaded the windows file and am using smoke, currently testing camilla version. Working good as far as I can tell! thanks for your work!

[netboy3]

@veryfungi, You are using the parasites version that only includes Smoke and Splash. If you want the rest of the Southpole plugins, please download and install the Southpole module (just scroll a little bit up to another post I made).

[veryfungi]

I realized the error of my post and edited it. thanks again!

[veryfungi]

Thank you again netboy3 for making these available. I made a video using CornrowsX and Smoke in Camilla time stretch mode. Everything appears to be working with these. Of course there are improvements that could be made. For example the octave control on CornrowsX goes from 0 to 1, yet spans several octaves. Right clicking and typing -2 will put it one octave down instead of the expected 2 octaves. And of course CornrowsX crashes rack when you right click on the module. https://youtu.be/Ehd8utEV0tE

[netboy3]

Hi @veryfungi. You are using an old, buggy version of Southpole (not the parasites plugin). Please scroll up about 7 posts and download the Southpole I fixed and posted on Oct 18th above. I know you ar using the old one because I fixed the right-click crash, and also fixed the mode knob that was misaligned (and in your video it is misaligned).

Regarding the knob ranges - thanks for letting me know. This is more of a cosmetic fix. I was really interested to initially clean out all the major bugs so folks can use it. There are many more small items that can be fixed, but I rather do it once the original developer is responsive which unfortunately is not the case here.

[netboy3]

Maybe I need to make my post more clear. Southpole contains two plugins:

• Southpole (classic) that has about 23 modules, including CornrowsX
• Southpole (parasites) that has two modules. Those two (Smoke and Splash) are also available in the classic version, but here they use a different firmware emulation that gives them different dynamics and have a few additional modes.

[veryfungi]

Hi netboy3, I have just installed your version. Thanks for pointing it out. :) I think CornrowsX sounds better with the knob aligned. :) I knew about the differences, but didn't realize you had fixed southpole too. Thanks again.

[Kleinemaschinen]

Hello gentlemen, I have just downloaded the Southpole zip and the Southpole parasites zip and put them in rack folder in plugins-v1 subfolder and now VCV Rack crashes every time I search for a module. Is this normal for these Southpole updated Nov 2019 updates to version 1? Please see attached screen snips:

[Kleinemaschinen]

Thanks to people on VCV Community, the problem was an update from Squinky labs. So the problem as now been resolved. Thanks for your time Mr Russell.