search

gbrandt1 / southpole-vcvrack

Southpole Modules for VCV Rack
Other
67 stars 24 forks source link

V1 parasites #49

Open netboy3 opened 5 years ago

netboy3 commented 5 years ago

This PR ports parasites to Rack API V1. I'm not sure if the VCV plugin manager is able to deal with two separate plugins under a single repo, so we might need to push parasites into a new repo.

SteveRussell33 commented 5 years ago

Andrew has said this before that each plugin has to be separate. That's why it's (v0.6) listed in the plugin library as two separate entries that you have to build yourself and not part of one's logged in account - ie Rack would tell you if there's an update - one has to do it manually.

BTW you've left out the entry to read the reverse value from json https://github.com/gbrandt1/southpole-vcvrack/blob/1e3ec8118a2b183d8db5cb8d24c488c410c3c594/src/Smoke.cpp#L134-L137

netboy3 commented 5 years ago

@SteveRussell33, I believe you are incorrect. The plugin "slug" manifest attribute creates the uniqueness of the plugin. The plugin "name" attribute is used to label your plugin in the plugin library. The "brand" attribute is not used in the library. It is used by the plugin itself as a prefix to the module name when you call the right-click menu. My concern is whether the library build system understands git enough to switch to a different branch based on a commit hash which I think it isn't. To be on the safe side, when the time comes, we will probably need to push parasites to a different repo.

SteveRussell33 commented 5 years ago

I edited my post, so it seemed there was some miscommunication - no worries. I tested both and all models appear under Southpole in the module browser. The library will have to have two separate entries as it does atm, just have to update them for v1.0 with separate repos so that updates are separated and it works with ones library account.

The missing code needs to be added otherwise it'll break patches.

netboy3 commented 5 years ago

Oh - looks like our responses crossed the wire :smile:. What missing code needs to be added? The slugs of all plugins and modules are compatible and I've tested the builds with old 0.6 patches.

SteveRussell33 commented 5 years ago

Read my first post - I had edited it (again!) to include the code that's missing.

netboy3 commented 5 years ago

Good catch! Fixed. I truly appreciate having another pair of eyes going through so much reworked code. Thanks!

SteveRussell33 commented 5 years ago

No problem, glad to help!

keyboarder61 commented 3 years ago

Dont know if is the correct place, but i experience a super low output volume of texture synth on parasites, even with the blend knob all the way down...