gbrian / grafana-timelion-datasource

ELK Timelion's data source for Grafana
MIT License
15 stars 12 forks source link

Fixes for publishing #19

Closed daniellee closed 5 years ago

daniellee commented 5 years ago

Please excuse the long delay. The links that I mention in my review were still not fixed so I fixed them and optimized the images to be smaller in size.

I also added a little fix for tags - it has to be an array and it splits on comma if there are multiple tags. Not sure though if that matches up with how tags would work in Timelion?

gbrian commented 5 years ago

Done, just had to fix a weird thing for tags not defined by user. When a new annotation is created the tags field is an empty array, then a string and if you clear/remove the tags the value is null 😩 Tested with Grafana6 and Elastic demo https://demo.elastic.co/api/timelion

image

gbrian commented 5 years ago

Any news @daniellee 😄 Thanks