search

gbrian / grafana-timelion-datasource

ELK Timelion's data source for Grafana
MIT License
15 stars 12 forks source link

Use Lucene interpolation engine for variables #6

Closed nbarrientos closed 6 years ago

nbarrientos commented 6 years ago

It's likely that when using templates the variables will end up in the 'q' parameter of the Timelion query. Following what the ElasticSearch plugin does the expected syntax there is Lucene so it's probably a good idea to interpolate multi-valued variables using that syntax.

Currently, a multi-valued variable will be replaced as:

{"a","b"}

whereas

("a" OR "b")

probably makes more sense.

I have zero experience with Grafana plugins so perhaps this does not make sense at all 😁. Also, the tests might not pass.

nbarrientos commented 6 years ago

Ping.

SergeiSafrigin commented 6 years ago

Ping.

gbrian commented 6 years ago

Ops!! Sorry @nbarrientos github is not sending me notifications :( checking