search

gbrlsnchs / telescope-lsp-handlers.nvim

MIT License
90 stars 9 forks source link

Update lsp handler function to new format #4

Closed rmagatti closed 3 years ago

rmagatti commented 3 years ago

Since the merging of this Neovim PR the function signature for an LSP handler is slightly different. https://github.com/neovim/neovim/pull/15504

This PR updates it to the new signature. There is probably a way to make this backwards compatible but I'll leave that decision to you.

gbrlsnchs commented 3 years ago

Oof, that's a good change by upstream, but a breaking one. And now that 0.5 is released, it should have preference over nightly... so I think I'll create a new branch just to dump nightly patches.

Also, thanks for sending this PR, I'll soon merge it with the new branch!

gbrlsnchs commented 3 years ago

Another possible solution would be similar to this.

rmagatti commented 3 years ago

Yeah I did something similar in one of my plugins, actually used debug.getinfo to get the number of params of the function called. Not sure what would be the best way of doing it for this plugin though. 🤔

gbrlsnchs commented 3 years ago

Your approach seems good enough IMO.

rmagatti commented 3 years ago

@gbrlsnchs quick change based on what you linked to make it backwards compatible.

gbrlsnchs commented 3 years ago

Thanks!!! Merging...