Consolidate order price fetching to a single method

gbrodman / order-tracking

Automated Amazon and Best Buy order tracking for buying groups

GNU Affero General Public License v3.0

33 stars 13 forks source link

Consolidate order price fetching to a single method #168

Closed CydeWeys closed 4 years ago

gbrodman commented 4 years ago

Does this solve the issue you were seeing? If that issue was caused by calling get_order_info multiple times for the same tracking number, wouldn't it still happen here?

CydeWeys commented 4 years ago

This just removes the duplicate code and adds a progress bar for the second call.

I can't say whether the 2nd call is even necessary at all; is it?

CydeWeys commented 4 years ago

Ended up going a different direction with it. It turns out it doesn't matter whether or not we populate the email ids since we only merge on them once, so I simplified that bit.