gbtami / pychess-variants

Chess variant server
https://www.pychess.org
GNU Affero General Public License v3.0
236 stars 115 forks source link

Xiangqi Piece Sets #1461

Closed Eventlesstew closed 4 months ago

Eventlesstew commented 4 months ago

I made two piece sets for Xiangqi. One set has guides to help people get used to the Hanzi while the other removes those guides for those who prefer it just for how it looks.

I tried making a pull request but gave up because I have no idea how to delete commits I don't need. (I don't mean to be nitpicky, but what's wrong with implementing a simple X button?) Guided.zip Basic.zip

randompearl-stack commented 4 months ago

Before making changes, you should update the branch you are merging with to the parent repository (sync fork), so any previous commits will already be reflected.

gbtami commented 4 months ago

Also the preferred way to create PRs is first create a branch for your PR work (don't work in the master branch!). This way only commits in that branch will be affected in a particular PR. Deleting commits in git is not possible. git is a VCS (version control system) designed to preserve all versions of your source files, but you can do git revert which will undo a particular git commit.

Eventlesstew commented 4 months ago

Before making changes, you should update the branch you are merging with to the parent repository (sync fork), so any previous commits will already be reflected.

Alright then

Eventlesstew commented 4 months ago

Also the preferred way to create PRs is first create a branch for your PR work (don't work in the master branch!).

This way only commits in that branch will be affected in a particular PR.

Deleting commits in git is not possible. git is a VCS (version control system) designed to preserve all versions of your source files, but you can do git revert which will undo a particular git commit.

I did create a new branch btw.

randompearl-stack commented 4 months ago

Are any of you going to add the piece sets?

gbtami commented 4 months ago

I planned, but had no time so far. If you can turn this into a PR it would be appreciated.

randompearl-stack commented 4 months ago

completed?