search

gbtami / pychess-variants

Chess variant server
https://www.pychess.org
GNU Affero General Public License v3.0
236 stars 115 forks source link

shogi piece set #1636

Closed Mansindam closed 1 week ago

PraseodymiumSpike commented 2 weeks ago

a little odd some pieces have gradient and some dont

gbtami commented 2 weeks ago

9x9mansindam.svg is not usable for Shogi, because it is exact square shaped. Shogi board dimensions are little bit different. We have 3 checkered Shogi boards already. If you want to create a new one you can use them as starting point.

If you add a new piece set it have to be added to PIECE_FAMILIES at https://github.com/gbtami/pychess-variants/blob/master/client/variants.ts#L52 and also to static/preview.css (before https://github.com/gbtami/pychess-variants/blob/master/static/preview.css#L230) to let it selectable in board settings.

After thinking about it more, I started to like your idea to create a chess like set without those Shogi pentagonal frames, and face to face orientation. But the figures must have a little bit more uniform appearance in general. I mean they are too eclectic atm. I suggest everyone to read https://www.pychess.org/blogs/Internationalized_Pieces

gbtami commented 1 week ago

Some other notes.

  1. Piece sizes should be adjusted a bit to better suite to Shogi board squares.
  2. Some figures have a thick outline, some thin. Possible because you borrowed them from different sets. This should be fixed as well.
  3. As @CouchTomato87 mentioned in pychess chat "the gold general helmet is terribly misrepresented"

This is how it looks now compared to Shogi and Mansindam. https://i.imgur.com/hfdwVzm.png

gbtami commented 1 week ago

read https://discord.com/channels/634298688663191582/653203449927827456/1287728038326435841