Closed gbtami closed 5 years ago
Here is a draft of icons. I included two different shogi ones, one with a king and one with an international-style gold general by request. I prefer the king since it's universal, but I can leave the choice up to you.
Seems app.fontastic.me import has minor problems with capablanca and placement icons and major problems with makruk, sittuyin and xiangqi ones.
There is a faq with some suggestions here: http://fontastic.me/faq
Regarding the draft I like the seirawan, crazyhouse, makruk, sittuyin, shogi and xiangqi icons. (I agree with you that using shogi king is better choice.) Maybe one simple chancellor alone for capablaca would be better in my opinion. For placement I have no better idea :)
p.s. I'm still struggling to download from fontastic.me with "operation time out" or what :(
I find this issue https://github.com/andreaskoller/Fontastic/issues/1
After removing capablanca and placement icons from selection I was able to download crazyhouse, seirawan, shogi and standard. They are committed and you can see them in game info panel now.
Cool! I'll try to redo the other ones. I think for Xiangqi, I forgot to turn the text into a path. Also, I'm working on hawk and elephant pieces you can use for S-chess, but not sure where I should put them when I'm done.
Btw if you sign up to fontastic.me (it's free) you can try to import icons yourself to see are they OK or not. http://fontastic.me/faq If you have problems just join to PyChess on discord at https://discord.gg/Yxn7V2z
Regarding hawk and elephant you can use github itself :) It's easy!
git clone https://github.com/CouchTomato87/pychess-variants.git
(Now you have a copy of your github project on your PC)cd pychess-variants
static/images/pieces/merida
git add static/images/pieces/merida/*.svg
git commit -m "Some descriptive short message what is this" static/images/pieces/merida/*.svg
git push
I got a little lost after installing. I tried putting them on github after forking, but I have no idea if I'm doing this right. All this is a little beyond me haha.
Here are the fixed icons. The problem was that a stroke completely messed up the icon. I also included the elephant and hawk in case my sad attempt at a pull request didn't work. Icons 2.zip
No worries :) Hawk and elephant are cool, thx a lot! (I just noticed that elephants are looking to the right while knights and hawks to the left.) I'v committed them so you can try them now. Still no luck with fixed icons on fontastic.me Download timeout :(
No problem! And sorry, the direction totally slipped my mind. Here are the fixed images. I also slightly tweaked the black hawk as well. ElephantHawk.zip
Thx! I"m in summer karate training camp this week. Next time is sunday when I can try your work.
Elephants committed. The black hawk in this .zip file is the same as before.
The black hawk is very slightly different. The mouth has been adjusted so that it's smoother.
Actually, I will probably have to do slight readjustments anyways... The OCD part of me sees that their vertical alignment is not consistent with the other pieces, so I'll have to fix that.
Here it is -- hopefully the last! I also resized the elephants and aligned them as much as I could with the other pieces. I forgot that unlike xiangqi and probably shogi, the chess pieces aren't center aligned. ElephantHawk3.zip
Committed, thx!
Finally I was able to fix some icons to let fontastic love them :) If you feel any piece or icon needs more adjustment feel free to reopen this issue.
Something like these, but for Makruk, Shogi etc.![icons](https://user-images.githubusercontent.com/479964/60735993-bf2dd800-9f55-11e9-9a64-c9fe5877707b.png)