search

gbtami / pychess-variants

Chess variant server
https://www.pychess.org
GNU Affero General Public License v3.0
235 stars 114 forks source link

Variants needs stylized icons #3

Closed gbtami closed 5 years ago

gbtami commented 5 years ago

Something like these, but for Makruk, Shogi etc. icons

CouchTomato87 commented 5 years ago

Icons.zip

Here is a draft of icons. I included two different shogi ones, one with a king and one with an international-style gold general by request. I prefer the king since it's universal, but I can leave the choice up to you.

gbtami commented 5 years ago

Seems app.fontastic.me import has minor problems with capablanca and placement icons and major problems with makruk, sittuyin and xiangqi ones. fontastic

There is a faq with some suggestions here: http://fontastic.me/faq

gbtami commented 5 years ago

Regarding the draft I like the seirawan, crazyhouse, makruk, sittuyin, shogi and xiangqi icons. (I agree with you that using shogi king is better choice.) Maybe one simple chancellor alone for capablaca would be better in my opinion. For placement I have no better idea :)

p.s. I'm still struggling to download from fontastic.me with "operation time out" or what :(

gbtami commented 5 years ago

I find this issue https://github.com/andreaskoller/Fontastic/issues/1 After removing capablanca and placement icons from selection I was able to download crazyhouse, seirawan, shogi and standard. They are committed and you can see them in game info panel now. shogi

CouchTomato87 commented 5 years ago

Cool! I'll try to redo the other ones. I think for Xiangqi, I forgot to turn the text into a path. Also, I'm working on hawk and elephant pieces you can use for S-chess, but not sure where I should put them when I'm done.

gbtami commented 5 years ago

Btw if you sign up to fontastic.me (it's free) you can try to import icons yourself to see are they OK or not. http://fontastic.me/faq If you have problems just join to PyChess on discord at https://discord.gg/Yxn7V2z

gbtami commented 5 years ago

Regarding hawk and elephant you can use github itself :) It's easy!

  1. Install git on your local PC https://git-scm.com/book/en/v2/Getting-Started-Installing-Git
  2. Create your own fork of this project Just click on "Fork" button at the top right, next to the "Stars". (Now you have your own copy of this project on github.)
  3. Create a local clone to your PC of your fork git clone https://github.com/CouchTomato87/pychess-variants.git (Now you have a copy of your github project on your PC)
  4. Go to your just created local copy cd pychess-variants
  5. Create and move new .svg piece files into static/images/pieces/merida
  6. Add new files to your local git repository git add static/images/pieces/merida/*.svg
  7. Commit this modification git commit -m "Some descriptive short message what is this" static/images/pieces/merida/*.svg
  8. Push to your local changes to your github repository git push
  9. Create a pull request to this upstream repo by clicking on "New pull request" button.
CouchTomato87 commented 5 years ago

I got a little lost after installing. I tried putting them on github after forking, but I have no idea if I'm doing this right. All this is a little beyond me haha.

CouchTomato87 commented 5 years ago

Here are the fixed icons. The problem was that a stroke completely messed up the icon. I also included the elephant and hawk in case my sad attempt at a pull request didn't work. Icons 2.zip

gbtami commented 5 years ago

No worries :) Hawk and elephant are cool, thx a lot! (I just noticed that elephants are looking to the right while knights and hawks to the left.) I'v committed them so you can try them now. Still no luck with fixed icons on fontastic.me Download timeout :(

CouchTomato87 commented 5 years ago

No problem! And sorry, the direction totally slipped my mind. Here are the fixed images. I also slightly tweaked the black hawk as well. ElephantHawk.zip

gbtami commented 5 years ago

Thx! I"m in summer karate training camp this week. Next time is sunday when I can try your work.

gbtami commented 5 years ago

Elephants committed. The black hawk in this .zip file is the same as before.

CouchTomato87 commented 5 years ago

The black hawk is very slightly different. The mouth has been adjusted so that it's smoother.

CouchTomato87 commented 5 years ago

Actually, I will probably have to do slight readjustments anyways... The OCD part of me sees that their vertical alignment is not consistent with the other pieces, so I'll have to fix that.

CouchTomato87 commented 5 years ago

Here it is -- hopefully the last! I also resized the elephants and aligned them as much as I could with the other pieces. I forgot that unlike xiangqi and probably shogi, the chess pieces aren't center aligned. ElephantHawk3.zip

gbtami commented 5 years ago

Committed, thx!

gbtami commented 5 years ago

Finally I was able to fix some icons to let fontastic love them :) If you feel any piece or icon needs more adjustment feel free to reopen this issue.