search

gbtb16 / kiwi

A simple compile-time dependency injection library for Dart and Flutter
MIT License
351 stars 51 forks source link

Update referenced build_runner version #85

Closed mvarendorff closed 8 months ago

mvarendorff commented 2 years ago

The current documentation for the generator package leads to errors when installing the packages.

This PR updates the Readme to reference build_runner 2 which installs just fine.

vanlooverenkoen commented 1 year ago

Build failed. I will update everything today. & make sure we have a more consistent update process for dependencies.

mvarendorff commented 1 year ago

I appreciate it! Quick note though: The change I made was purely related to documentation, I am not sure why the build failed, to be honest but I believe this PR is still relevant:

https://github.com/vanlooverenkoen/kiwi/blob/849dc158bc4cd8e84d869b9b8eafb532979cd41e/kiwi_generator/README.md?plain=1#L24

This version of build_runner will cause errors when trying to install the packages. The package itself depends on build_runner 2 in its dev_dependencies:

https://github.com/vanlooverenkoen/kiwi/blob/849dc158bc4cd8e84d869b9b8eafb532979cd41e/kiwi_generator/pubspec.yaml#L21

While the packages in the pubspecs are updated now, the documentation isn't.

vanlooverenkoen commented 1 year ago

Hoooow right, my bad.

vanlooverenkoen commented 1 year ago 
buid_runner: 2.3.3

is now used. Also pull master into your branch

gbtb16 commented 8 months ago

Hi @geisterfurz007, your implementation was used as a basis in PR #102. I'm going to close this PR since the changes are already in the master. Thanks for your contribution!