gburd / szl

Automatically exported from code.google.com/p/szl
Other
0 stars 0 forks source link

tot_elems_ uninitialize in class SzlMaximumEntry and SzlQuantileResults construction. #26

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Their base class SzlTabEntry has member tot_elems_ so no need to redefine.

PATCH:
Index: src/emitters/szlmaximum.cc
===================================================================
--- src/emitters/szlmaximum.cc  (revision 53)
+++ src/emitters/szlmaximum.cc  (working copy)
@@ -91,7 +91,6 @@
       return sizeof(SzlMaximumEntry) + heap_.Memory() + sizeof(SzlValueCmp);
     }

-    virtual int64 TotElems() const { return tot_elems_; }
     virtual int TupleCount() { return heap_.nElems(); }

     const SzlOps& weight_ops() const  { return weight_ops_; }
@@ -103,9 +102,6 @@
     // TODO: Add an iterator for sorted output to improve
     // FlushForDisplay performance.
     SzlHeap heap_;
-
-    // Total elements ever added to the table.
-    int64 tot_elems_;
   };
 };

Index: src/emitters/szlquantileresults.cc
===================================================================
--- src/emitters/szlquantileresults.cc  (revision 53)
+++ src/emitters/szlquantileresults.cc  (working copy)
@@ -89,14 +89,11 @@

   virtual const vector<string>* Results()  { return &quantiles_; }

-  virtual int64 TotElems() const  { return tot_elems_; }
-
  private:
   SzlType type_;  // the type of the table
   SzlOps ops_;   // Operations on our element type, for parsing.
   vector<string> quantiles_;
   const int num_quantiles_;
-  int64 tot_elems_;

   void Clear() {
     quantiles_.clear();

Original issue reported on code.google.com by gzc9047@gmail.com on 19 Jan 2013 at 4:53

GoogleCodeExporter commented 9 years ago
I got a mistake, SzlQuantileResults has no problem, only SzlMaximumEntry need 
fix.

Sorry for my fault.

Original comment by gzc9047@gmail.com on 19 Jan 2013 at 9:48