gbv / Catmandu-PICA

Catmandu modules for working with PICA+ data
https://metacpan.org/release/Catmandu-PICA
Other
4 stars 4 forks source link

Tests may fail (with older PICA::Data?) #54

Closed eserte closed 6 years ago

eserte commented 6 years ago

On some of my smokers t/04-exporter.t fails:

#   Failed test at t/04-exporter.t line 86.
#          got: '<?xml version="1.0" encoding="UTF-8"?>
# <collection xlmns="info:srw/schema/5/picaXML-v1.0">
# <record>
#   <datafield tag="003@">
#     <subfield code="0">1041318383</subfield>
#   </datafield>
#   <datafield tag="021A">
#     <subfield code="a">Hello $Â¥!</subfield>
#   </datafield>
# </record>
# <record>
#   <datafield tag="028C" occurrence="01">
#     <subfield code="d">Emma</subfield>
#     <subfield code="a">Goldman</subfield>
#   </datafield>
# </record>
# </collection>
# '
#     expected: '<?xml version="1.0" encoding="UTF-8"?>
# 
# <collection xmlns="info:srw/schema/5/picaXML-v1.0">
#   <record>
#     <datafield tag="003@">
#       <subfield code="0">1041318383</subfield>
#     </datafield>
#     <datafield tag="021A">
#       <subfield code="a">Hello $Â¥!</subfield>
#     </datafield>
#   </record>
#   <record>
#     <datafield tag="028C" occurrence="01">
#       <subfield code="d">Emma</subfield>
#       <subfield code="a">Goldman</subfield>
#     </datafield>
#   </record>
# </collection>
# '
# Looks like you failed 1 test of 4.
t/04-exporter.t ........ 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/4 subtests 

Statistical analysis suggests that it passes only with PICA::Data 0.34 --- so probably the minimum prerequisite version should be adjusted.

****************************************************************
Regression 'mod:PICA::Data'
****************************************************************
Name                   Theta          StdErr     T-stat
[0='const']           0.0000          0.0000      10.09
[1='eq_0.34']         1.0000          0.0000    91646440343380832.00

R^2= 1.000, N= 63, K= 2
****************************************************************
jorol commented 6 years ago

Thanks a lot for your work and bug reports! Fixed with #56