gbv / SignaturenDruck

An electron application to print shelfmarks onto labels
https://verbundwiki.gbv.de/display/VZG/SignaturenDruck+der+ThULB+Jena
Creative Commons Zero v1.0 Universal
3 stars 2 forks source link

New File in Directory Formate leads to an issue #17

Closed moehrlich closed 5 years ago

moehrlich commented 5 years ago

If you accidentaly add an new file to the Formate Directory the system does not know what it has to do with that file and did not starts correctly. It should ignore these file or should show a error message.

EliDeh commented 5 years ago

A error message will be added

jsubhi commented 5 years ago

Non-json Files are ignored now - good. But any invalid json file in the Formate directory seems to force default values on all other settings in the program. The settings in config.json and all the formats no longer apply. This behaviour can be reproduced by adding an empty "test.json" to Formate or by adding an extra comma to default_gross.json for example. Not a major issue but a more robust handling would be nice, e.g. quitting with "invalid configuration in test.json"

jsubhi commented 5 years ago

Looks good now. Thanks!