gbv / SignaturenDruck

An electron application to print shelfmarks onto labels
https://verbundwiki.gbv.de/display/VZG/SignaturenDruck+der+ThULB+Jena
Creative Commons Zero v1.0 Universal
3 stars 2 forks source link

Default Regex for Location applied when editing existing submode #67

Closed jsubhi closed 4 years ago

jsubhi commented 4 years ago

When editing an existing submode, the fields "Standort" and "RegEx Standort" are filled with the default values from config.json even if the submode was previously saved without a "RegEx Standort". One has to remember to empty the "RegEx Standort" field before saving the modifications otherwise an incorrect location filter will be applied for this submode.

jsubhi commented 4 years ago

Unfortunately not fixed in 1.1.1-g.

How to reproduce:

Expected behaviour: Fields "Standort" and "RegEx Standort" are empty or show only greyed-out sample content. "locRegEx" is only added if one explicitly types somthing into the corresponding field.

Current behaviour is very problematic since one can accidentally add a filter that in most cases would render the entire format non-functional.

Maybe it would be easiest to just skipt the whole "Sample Location" and just leave the field empty unless the user adds some content?

EliDeh commented 4 years ago

Thank you for the detailed report. I just released a hotfix.

jsubhi commented 4 years ago

Works as expected now! Thanks for the quick fix!