search

gbv / cmo

Corpus Musicae Ottomanicae
GNU General Public License v3.0
6 stars 0 forks source link

Update Basket: displayed attributes #185

Closed fabiancremer closed 5 years ago

fabiancremer commented 5 years ago

Display:

Source:

Literature:

Works:

Expressions:

fabiancremer commented 5 years ago

Request for Milestone "maintenance and update session 09/19"

sebhofmann commented 5 years ago

Not sure if the literature already works.

kkrebs commented 5 years ago

You can look for articles in sources: https://corpus-musicae-ottomanicae.de/servlets/solr/select?q=category.top:%22cmo_genres:article%22%20AND%20category.top:%22cmo_kindOfData:source%22

and putting these in your basket. Than the publication date is missing.

kkrebs commented 5 years ago

fixed also solr document in mycore-mods https://github.com/MyCoRe-Org/mycore/pull/870/commits/a752d68a01032f2df8d4dfc5960d1be9a696bf41

annplaksin commented 5 years ago

The publication date of http://cmo.gbv.de/cmo-test/receive/cmo_mods_00000020 is still not visible in the basket when you got to it via http://cmo.gbv.de/cmo-test/receive/cmo_source_00000059 Is this because of the "ca." in the publication date? It works for http://cmo.gbv.de/cmo-test/receive/cmo_mods_00000027 though...

And could it be possible, when merging the author and editor field for sources, that the names are not doubled (one is clickable and the other not)? It seems confusing to me otherwise...

kkrebs commented 5 years ago

Sorry, the solr index wasn't up to date. Now it works.

The author and editor field for sources is confusing, you are right. I put the following sources in the basket, than you can see the problem: http://cmo.gbv.de/cmo-test/receive/cmo_source_00000051 http://cmo.gbv.de/cmo-test/receive/cmo_source_00000060 http://cmo.gbv.de/cmo-test/receive/cmo_source_00000063

There are some names without links, which is ok (we have no person linked for them). But if we have a person, this link was shown once again. On the metadata page we shorten the link name, e.g.:

Belediye Konservatuvarında Tarihî Türk musikisi eserlerini tetkik ve tasnif heyeti azasından Dr. Suphi Subhî Ezgi

How should it be in basket view? Should we set the link on the name? Or do it in the same way as in metadata perspective? Or should we remove the links?

annplaksin commented 5 years ago

Is it possible to show only the link, if the name has one, and for names without links the plain text? And I would tend to give the shortened link name like on the metadata page for names with links.

annplaksin commented 5 years ago

I also noticed, that for expressions in the basket view, composers without links in the database are not visible in the basket.

You could see this by adding that expression to the basket: http://cmo.gbv.de/cmo-test/receive/cmo_expression_00005654

I don't think this is very urgent, since it is very unlikely that a composer will not have its own person entry in the database. So this is mostly mentioned for the sake of uniformity.