search

gbv / cmo

Corpus Musicae Ottomanicae
GNU General Public License v3.0
6 stars 0 forks source link

Display title instead of CMO-ID for child elements #204

Closed ja-roh closed 3 years ago

ja-roh commented 4 years ago

In expressions that have "children", they are displayed with CMO-IDs, whereas the sorting follows the titles, which leads to confusion. Could we change the method of displaying?

annplaksin commented 4 years ago

According to my notes, we agreed on displaying the titles for children of expression because, as far as I remember, the sorting is already done by title. Or am I wrong?

zhelvaci commented 4 years ago

You are right Anna, I think it is just not implemented so far.

kkrebs commented 4 years ago

Do you mean the order problem eg here: https://corpus-musicae-ottomanicae.de/receive/cmo_expression_00003692 ? We discussed the problem in issue #167 right? So we need a new solr field that contains the same string shown in this list and we sort the list using this field. Than the displayed order would be correct.

zhelvaci commented 4 years ago

Yes, the issue was discussed in #167 and it was clarified that the problem in the abovementioned example was the missing makam (I just corrected that). The current problem is only about displaying the children with titles instead of CMO-IDs to make the user the content of the dataset clear (and to be consistent with the ordering). E.g.: https://corpus-musicae-ottomanicae.de/receive/cmo_expression_00004580 We are now adding [1], [2], etc. to the titles of such children for the correct order.

kkrebs commented 3 years ago

We discussed this and decided to show [CMO-ID] - [Title] and sort the list using CMO-ID. This should solve all problems discussed here.

NE208, p. 013/1 - Beste-yi evvel ūṣūli çenber NE208, p. 013/2 - Beste-yi s̱ānī ūṣūli NE208, p. 014 - Aḳṣaḳ semāʿī Bekr Āġānıñ NE208, p. 015 - Yürük semāʿī İsmāʿīl Efendi

ja-roh commented 3 years ago

Seems to work