search

gbv / cocoda

A web-based tool for creating mappings between knowledge organization systems.
https://coli-conc.gbv.de/cocoda/
MIT License
39 stars 5 forks source link

Support concept schemes without notations #154

Closed nichtich closed 5 years ago

nichtich commented 5 years ago

For instance this concept scheme and this example mapping.

stefandesu commented 5 years ago

In theory, there should be no problems with concepts without notations. Specifically with "Diskordianismus", there seems to be an error in DANTE, see the URI of the first concept of this request. But we do need a way to display mappings that include concepts without notations. I guess instead of the notation, we just display the (potentially truncated because of length) prefLabel?

stefandesu commented 5 years ago

Question regarding your second example:

The mapping that is loaded from the server is actually a WIKIDATA - GND Mapping (it's showing the concept schemes on my local machine, not sure why it's not showing on dev), and that particular Wikidata concept on the left side DOES have a notation which is Q7340. Interestingly, it is not loaded on your link because the query with only the to parameter does not return a notation for the from side. If you actually select that concept on the left side (currently not possible because no notation is shown), a different query with only the from parameter includes the notation (for both sides). Also, the query for the detail data of that concept doesn't return a notation either.

stefandesu commented 5 years ago

My second comment doesn't have anything to do with this particular issue, and prefLabel was now added as a fallback for ItemName, so I'm closing this issue.