search

gbv / cocoda

A web-based tool for creating mappings between knowledge organization systems.
https://coli-conc.gbv.de/cocoda/
MIT License
39 stars 5 forks source link

Identity: Namechanges do not get applied to mappings #326

Closed DennisTobola closed 5 years ago

DennisTobola commented 5 years ago

If you edit and save a mapping, it shows your name as the creator. But when changing your Name the changes do not get applied to the saved mapping, the name stays the same as before, although it ought to have changed.

stefandesu commented 5 years ago

This is actually a new feature, not something that was supposed to happen (as you say). Currently, there is a button Settings -> Local Mappings -> Rewrite creator for all local mappings which does exactly what you want. If @nichtich agrees, we can do that automatically for every change in the identity.

Note that this would only apply for local mappings. Theoretically, we could implement a method in jskos-server to batch rewrite mapping creators, but it's not there yet.

nichtich commented 5 years ago

It's a usability issue: If user X has saved a mapping in jskos-server, later changes his name and opens the same mapping than:

How should a user know how to change the name in jskos-server? The name mismatch should be indicated somehow, and re-saving of the mapping should be possible, no?

stefandesu commented 5 years ago

@nichtich What you're describing is different from how I interpreted @DennisTobola's issue. You're right: It should be possible to save a mapping if only the name has changed. But that requires deeper changes in Cocoda because currently it is using the identifier which doesn't seem to include the creator (or there's some other bug). But in any case, that's something that is solvable relatively easily.

How I interpreted the original issue was that when I go to settings and change my name, all my existing mappings will automatically get the new name associated with them. For local mappings, that would be the same as "Rewrite creator for all local mappings" in settings, just for every name change. For remote mappings, we'd need to have a way to batch rewrite the creator for potentially lots of mappings.