search

gbv / cocoda

A web-based tool for creating mappings between knowledge organization systems.
https://coli-conc.gbv.de/cocoda/
MIT License
39 stars 5 forks source link

Support undo of mapping deletion and a "trash bin" for deleted mappings #354

Closed stefandesu closed 5 years ago

stefandesu commented 5 years ago
DennisTobola commented 5 years ago

I would try to put the trash bin in between 'feedback' and the star for favorites. Any settings can then be adjusted in 'Settings' -> 'Trashbin' (new subitem). These are just suggestions, whether you implement them or not is up to you.

stefandesu commented 5 years ago

Not sure about adding a new tab to settings just for this, but we can try to put it in the navbar.

I also forgot to mention that I would add a Ctrl/Cmd + z shortcut to undo the last deletion, but depending on how you look at this it can get complicated quickly. Like, should it also undo creating or editing a mapping? Should it still undo deletion if it happened half an hour ago? And so on. Any thoughts on this?

nichtich commented 5 years ago

Not everything needs to be undoable. Registries can support version history but that would be another issue. -- Jakob Voß via Android

stefandesu commented 5 years ago

Requires #356.

stefandesu commented 5 years ago

Note: This would not be a traditional "undo" of deletion of a mapping, but rather a "restore" in the sense that it will be saved again. This means that it will get the latest modified date as well as a new URI (in case of jskos-server at least). I don't think that this is a problem, but it's a caveat to keep in mind.

stefandesu commented 5 years ago

jskos-server now allows a pre-given URI when POSTing a mapping, so that at least the URI can remain the same. Local mappings already have support for this.

stefandesu commented 5 years ago

Please try out the first implementation of this idea in dev.

Some notes: