search

gbv / cocoda

A web-based tool for creating mappings between knowledge organization systems.
https://coli-conc.gbv.de/cocoda/
MIT License
39 stars 5 forks source link

Empty creator name when logged in via GitHub? #521

Closed nichtich closed 4 years ago

nichtich commented 4 years ago

A new user, logged in via GitHub created mappings but the creator name ended up empty, e.g.

https://coli-conc.gbv.de/api/mappings/272d07c2-ed04-4c0e-9564-1e7ec14fbe92

I think the mapping was copied from mapping recommendations. Anyway: if the creator/contributor name is an empty string than don't store it. If no creator/contributor name is given show an (abbreviated) URI instead

stefandesu commented 4 years ago

Not only did the creator name end up empty, the property creator doesn't even exist! And contributor has three entries which is super weird as well. I'm going to try to figure this out.

stefandesu commented 4 years ago

I can't really reproduce what that person has done, but I've found the issue which removed the creator property, so this shouldn't happen anymore.

I will keep this open because I've just had an idea how that person could have gotten an empty creator name.

stefandesu commented 4 years ago

The issue in login-server which has caused the user to have an empty name is now fixed. 👍