search

gbv / cocoda

A web-based tool for creating mappings between knowledge organization systems.
https://coli-conc.gbv.de/cocoda/
MIT License
39 stars 5 forks source link

Inconsistencies with LabelSearchSuggestionProvider #650

Closed stefandesu closed 2 years ago

stefandesu commented 2 years ago

Cocoda uses a truncated prefLabel when inserting the label in the search field on the opposite side. However, LabelSearchSuggestionProvider uses the full prefLabel, which means that the results won't match what the Cocoda search shows (and it will provide fewer or no results). It might make sense to change LabelSearchSuggestionProvider to use a truncated label as well.

See also: https://github.com/gbv/cocoda-sdk/issues/40

Example: https://coli-conc.gbv.de/cocoda/app/?fromScheme=http%3A%2F%2Fbartoc.org%2Fen%2Fnode%2F241&toScheme=http%3A%2F%2Fbartoc.org%2Fen%2Fnode%2F1043&from=http%3A%2F%2Fdewey.info%2Fclass%2F612.6%2Fe23%2F (No results for LabelSearchSuggestionProvider/coli-conc recommendations, but one result in search)

stefandesu commented 2 years ago

The next release (v3) of cocoda-sdk will include an updated LabelSearchSuggestionProvider which behaves the same as Cocoda's insertPrefLabel. I'll close this issue as soon as it's updated here.

stefandesu commented 2 years ago

Fixed in dev.