gbv / cocoda

A web-based tool for creating mappings between knowledge organization systems.
https://coli-conc.gbv.de/cocoda/
MIT License
40 stars 5 forks source link

MappingEditor: Cross-user mappings are always shown as "not saved" #685

Closed stefandesu closed 2 years ago

stefandesu commented 2 years ago

Before, we didn't really have a use case for cross-user mapping editing, but now with #623, this could become more common (i.e. editing a mapping from another user in a concordance both of us have access to). Currently, when editing such a mapping in MappingEditor, it is always shown as "not saved" even without changes. The reason: MappingEditor by default overrides the creator of a mapping with oneself. (When the mapping is saved, jskos-server overrides this logic again and keeps the original creator.) Before doing this, it should check whether the mapping that is edited belongs to the current user, and if not, only add the current user to contributors which, I think, shouldn't be detected as "mapping was changed, but not saved".