search

gbv / cocoda

A web-based tool for creating mappings between knowledge organization systems.
https://coli-conc.gbv.de/cocoda/
MIT License
39 stars 5 forks source link

Annotations: Take content identifier into account #687

Open stefandesu opened 2 years ago

stefandesu commented 2 years ago

jskos-server now automatically adds a mapping's content identifier to an annotation if possible: https://github.com/gbv/jskos-server/issues/173

This means we can now compare this identifier (annotation.target.state.id) to the mapping's current content identifier to see if the mapping has changed, and if it did, these annotations should not be taken into account. (They can still be shown as "invalid" with a hint that the mapping has changed in the meantime.)

If possible, the creator of such an annotation should be able to update that annotation. This should perform a PATCH request that updates the identifier in target.state.id. We need to figure out a good UI to do this.

Should be taken into consideration for #682.

Related to https://github.com/gbv/cocoda/issues/667.

stefandesu commented 1 year ago

these annotations should not be taken into account

Update: This is probably too complicated. An easier solution would be to allow a mapping creator to delete these invalid annotations after they updated the mappings. This needs to be implemented in jskos-server. (Issue TBD.)