gbv / coli-ana

API to analyze DDC numbers
https://coli-conc.gbv.de/coli-ana/app/
MIT License
2 stars 0 forks source link

Extend user interface to query decompositions that use a given class #21

Closed nichtich closed 3 years ago

nichtich commented 3 years ago

With #20 the api supports an alternative query parameter. The user interface needs to be extended to support browsing decompositions via their members.

stefandesu commented 3 years ago

Any specific ideas on the implementation? We could definitely reuse the Analyze.vue component and make it aware of the two options. When searching via members, those members should be highlighted in the results.

nichtich commented 3 years ago

A more sophisticated interface might make sense for browsing the hierarchy enriched with composed classes but this is another issue and possible better located in Cocoda.

stefandesu commented 3 years ago

Okay, I'll give it a try later.

stefandesu commented 3 years ago

First implementation is now pushed to dev:

nichtich commented 3 years ago

currently nothing is displayed if there are no results for a lookup; there should be something

How about like "No decomposition found for:" but "Not found as part of any analysis:"?

nichtich commented 3 years ago

Adding a way to click on a member to perform a query would allow to browse around in the analysis. Maybe make the notation linked to an lookup query with this member and hover in blue?

stefandesu commented 3 years ago

I'm not sure if I completely understand how you imagine it, but I think it would be very irritating if a click on a member performed a completely different query and removed all your current results. You talk about "brows[ing] around in the analysis", but that's not how I imagine browsing to work. So maybe you could describe in more detail how you imagine it?

My suggestion would be to have a button in the popover, just like the open in Cocoda button, for every member.

Also, one unrelated question: Should we allow searching for multiple members at the same time? Currently, you can only search for one member. And if yes, should it be OR or AND? Both kind of make sense, so maybe we need another option...

nichtich commented 3 years ago

My suggestion would be to have a button in the popover, just like the open in Cocoda button, for every member.

ok!

Currently, you can only search for one member. And if yes, should it be OR or AND? Both kind of make sense, so maybe we need another option..

Parameter notation supports | for multiple notations as OR, so make it OR as well, this is also the more common use case AFAIK.

stefandesu commented 3 years ago

Parameter notation supports | for multiple notations as OR, so make it OR as well, this is also the more common use case AFAIK.

Makes sense! If at any point we also have a specific use case for AND, we can still implement a mode parameter or something. 👍

stefandesu commented 3 years ago

I will try to add pagination now and would close the issue afterwards.

stefandesu commented 3 years ago

Pagination and member lookup in ConceptDetails are now added in dev. @nichtich Please take a look and adjust the symbols if necessary.