gbv / coli-conc.gbv.de

project coli-conc homepage
https://coli-conc.gbv.de/
5 stars 4 forks source link

Replace /terminologies/ by dynamic list from BARTOC #43

Closed nichtich closed 2 years ago

nichtich commented 3 years ago

Align the list at https://coli-conc.gbv.de/terminologies/ with BARTOC and add

Listed In: http://bartoc.org/en/node/18926

so we can show an always updated list via the search http://bartoc.org/vocabularies?partOf=http://bartoc.org/en/node/18926. Ignore MARC and PICA unless it is empty in BARTOC (in doubt BARTOC is more up-to-date).

stefandesu commented 3 years ago

Should the list be fully dynamic, i.e. no more data is stored in this repository? We could also get the current list on each page build, so the page would remain fully static with no JavaScript.

The second option would be easy to implement as soon as all the relevant vocabularies are added to the registry in BARTOC.

nichtich commented 3 years ago

The second option would be easy to implement as soon as all the relevant vocabularies are added to the registry in BARTOC.

I think this option is enough to work with.

sabrinagaab commented 3 years ago

KOS_BARTOC.xlsx The KOS entries in the list under the given URL (https://coli-conc.gbv.de/terminologies/) are now updated (I added "Listed in" + URI for 32 entries). One entry of the given list could not be updated, see the issue above for more information.

nichtich commented 3 years ago

Ok, the list can now dynamically be queried from BARTOC: http://bartoc.org/vocabularies?partOf=http://bartoc.org/en/node/18926

stefandesu commented 3 years ago

Is Systematik für Evangelische Büchereien (SEB) (which is part of the current list on the website) not relevant anymore? I compared both lists and this is the only one missing.

sabrinagaab commented 3 years ago

https://github.com/gbv/bartoc.org/issues/128. "Listed In" cant be added because of an error (see the link for more information).

stefandesu commented 3 years ago

I made the change now. You can adjust the API call here. The list will be rebuilt every time the page is generated (i.e. on every push).

One remaining issue is that the list will be unavailable if the API call fails during page generation. Maybe we can have a static list as a backup.

nichtich commented 2 years ago

How can we enforce an update? Add a daily cronjob?

stefandesu commented 2 years ago

How can we enforce an update? Add a daily cronjob?

There should be a nightly update via a scheduled Github Action. As far as I can tell, it updated the site last night at 03:05:51 CET. Is there anything that you expected to be updated that wasn't? Maybe there is some other issue, e.g. with caching?

nichtich commented 2 years ago

Ok, then we can just wait a day if something has been changed in BARTOC (unless it is very urgent)

stefandesu commented 2 years ago

If you really want to rebuild the site without a new commit, you could go into the webhooks section in GitHub and simply resend the last webhook. ;)

sabrinagaab commented 2 years ago

Ergänzung in BARTOC (2).md Even though this issue was already closed, I wanted to add the progress i made while still working on it: As a continuation of the actual task, I had started - under agreement with @nichtich - to transfer the full KOS Registry click here from cocoda to Bartoc. I didn't finish it, but mabye it will come in handy.

stefandesu commented 2 years ago

Thanks @sabrinagaab!