search

gbv / jskos-cli

Command Line Applications to process JSKOS data format
MIT License
1 stars 1 forks source link

Fix tests #32

Open stefandesu opened 1 year ago

stefandesu commented 1 year ago

The tests don't work correctly, but I don't understand what is happening there. The convert-mappings test doesn't run at all. The problematic test is the previous one, in particular these lines:

https://github.com/gbv/jskos-cli/blob/8b0715cd4234efee7e8c852a0299fea3b99c841f/test/convert-concepts.js#L17-L18

I don't understand what is happening there. Since pipeline is asynchronous, done() is called before the pipeline is executed. But the pipeline itself doesn't make sense to me either. Where is the test? Nothing is tested there, only outputted to process.stdout for some reason. I wasn't able to fix it because I completely don't understand what's happening there. Moving done into the pipeline doesn't fix the issue either.

Can you take a look at this @nichtich?

(I found this while trying to update some dependencies, but I can't be sure everything still works correctly if the tests are broken.)

stefandesu commented 11 months ago

I decided to exclude the broken test until it's fixed.