gbv / jskos-server

Web service to access JSKOS data
https://coli-conc.gbv.de/api/
MIT License
6 stars 4 forks source link

Add filter of voc by partOf #143

Closed nichtich closed 3 years ago

nichtich commented 3 years ago

Extend /voc with query parameter partOf to filter vocabularies by collection URI. This field is used by BARTOC to indicate which registry a vocabulary is listed in.

We may also also add this parameter to /voc/{search,suggest} so we can use vocabulary search via backend in Cocoda. Alternatively Cocoda loads all vocabularies on intitialization and performs filtering client-side.

stefandesu commented 3 years ago

We may also also add this parameter to /voc/{search,suggest} so we can use vocabulary search via backend in Cocoda.

I'd love to do that, but the thing is: So far, filtering and text search are completely separate. The former is done on the entity endpoint (/voc in this case), the latter on the search/suggest endpoint. That's why in BARTOC, you can only either search or filter, not both.

However, I don't think that there is something that technically prevents us from combining it. The issue has rather been that we weren't sure how to change in API. Do we add search to the entity endpoint or add filter to the search endpoint? Does search support all the same filtering parameters as the entity endpoint?

That is definitely a separate issue, but I think it's worth thinking about. 👍