gbv / jskos-server

Web service to access JSKOS data
https://coli-conc.gbv.de/api/
MIT License
6 stars 4 forks source link

Change meaning of ip/identities for update/delete #154

Closed nichtich closed 1 year ago

nichtich commented 2 years ago

copied from this comment to an independent issue

This comment would make sense, not just for mappings/concordances, but for all entities:

nichtich commented 2 years ago

Sounds good, but wait until we actually need it. This may clash with creator and contributor at least when a user is not logged in but only get's privileges via ip.

stefandesu commented 2 years ago

Makes sense, better wait for a use case, but keep this solution in mind. 👍

nichtich commented 1 year ago

In https://github.com/gbv/cocoda/issues/693 we want selected users to be able to delete items of other creators for cleanup (no update!). So we could change implication of config key identities at delete so all accounts listed there can delete all items. Disadvantage: this may be confusing and it is not possible to configure a jskos-server instance for a set users, each editing their own items.

Better close this original issue and add a crossIdentities key for action update and delete:

stefandesu commented 1 year ago

We could also just used the existing crossUser key and allow it to be a list of URI strings (in addition to a boolean value). Its description matches exactly what we want and there would be no need to add a new config key.

stefandesu commented 1 year ago

Closed in favor of #184.