Group mappings in concordances - Githubissues

gbv / jskos-server

Web service to access JSKOS data

https://coli-conc.gbv.de/api/

MIT License

6 stars 4 forks source link

Group mappings in concordances #8

Closed nichtich closed 5 years ago

nichtich commented 6 years ago

This is a more complex issue but required to deliver mapping provenance metadata.

[x] add /concordance endpoint returning a list of concordances. A sample list (ndjson) is available at http://coli-conc.gbv.de/concordances/csv/concordances.ndjson
[ ] implement HTTP PUT at /concordance/xxxx where xxx can be [a-z0-9_-] to add a new concordance.
[ ] Add default REST operations (at least GET) to get data about a single concordance
[ ] Add optional parameter concordance when adding mappings to specify a concordance that the mappings result from. During import validation should make sure that mappings actually fit to the concordance. The concordance URI is added to each mapping in field partOf
[x] Support query parameter in to /mappings endpoint to filter mappings by concordance they belong to (this can be implemented independently)

nichtich commented 6 years ago

related to #5 (download-URLs need to be changed to absolute URLs)

stefandesu commented 5 years ago

This is now implemented as /concordances.
Question: What would xxxx be in this case? Wouldn't it be enough to add the whole concordance as a JSON object? Do we even want/need a PUT endpoint for this?
Not yet implemented (suggestion: add parameter uri= to /concordances).
When importing a concordance, the associated mappings can be imported as well. The import function to import mappings also supports a concordance option to specify the mappings' concordance. No validation is done for this yet.
/mappings now supports the partOf= parameter to specify the concordance (or concordances).

nichtich commented 5 years ago

We don't need update via HTTP by now, so closing this issue and adding #26 instead.