Closed nichtich closed 3 years ago
Yeah, I guess you're right. However, I would still like to make it as easy as possible to use it together with a cocoda-sdk registry. Can we still add the helper utilities or the additional components to jskos-vue?
(I think additional components would be nice, but helper utilities would be somewhat cleaner. As long as the documentation shows how to use it, I think helper utilities would be fine for this.)
This code smells because in contrast to the rest of jskos-vue it depends on a "registry" object that is not part of JSKOS specification:
https://github.com/gbv/jskos-vue/blob/dev/src/components/ItemSearch.vue#L104-L113
A solution may be to remove the
registry
property, makesearch
required and provide a helper function that generates a search function fromregistry
and/orscheme
. Another solution may be to create additional componentsConceptSuggest
, andSchemeSuggest
on top ofItemSuggest
in applications that make use of cocoda-sdk.