search

gbv / login-server

Login and connect accounts with multiple identity providers
https://coli-conc.gbv.de/login/
MIT License
32 stars 32 forks source link

Reduce user data for each identity #34

Closed nichtich closed 3 years ago

nichtich commented 5 years ago
stefandesu commented 5 years ago
  • what is identity field id required for? Do we need both, id and username?

Every identity always has the field id which is used to match a login attempt to existing identities in the database. Some identities also have a username. Imagine that you change your GitHub username. You will still be able to use the same login as before because your id hasn't changed, only your username. Either username or id are used to create an URI, depending on the provider (GitHub uses usernames, ORCID uses the ID).

This reminds me that this data should be updated every time a user uses that account to login, and maybe there should be a button to manually update the data.

stefandesu commented 3 years ago

Since I already explained id and just added removal of the username field if it's empty, I think we can close this issue.