Return empty list for concepts of unsupported concept schemes

gbv / subjects-api

JSKOS Concept Occurrences Provider implementation

https://coli-conc.gbv.de/subjects/

MIT License

0 stars 0 forks source link

Return empty list for concepts of unsupported concept schemes #11

Closed stefandesu closed 2 years ago

stefandesu commented 5 years ago

Right now, if a concept of an unsupported concept scheme is given, the API returns a 404 page, see this example. Wouldn't it be better if it just returned an empty list?

nichtich commented 2 years ago

Maybe, but then we have no information about why no results are returned.

stefandesu commented 2 years ago

Yeah, I mean this issue is almost three years old. Nowadays I would suggest providing a list of compatible concept schemes via the /status endpoint or something like that. We have mappings.fromSchemeWhitelist and mappings.toSchemeWhitelist, for example.