gc-da11yn / gc-da11yn.github.io

Digital Accessibility Toolkit - Boîte à outils d'accessibilité numérique
https://a11y.canada.ca/en/
MIT License
31 stars 33 forks source link

[CHANGE] Update to footer to GCWeb v12.6.1 #313

Closed shawnthompson closed 1 year ago

shawnthompson commented 1 year ago

What page is the change request for? Please supply the URI.

No response

Approval needed?

None

Yes, please send a request to the following person?

No response

Who shall do the work?

Timeline

No response

Additional context

Update the footer as per the email from principle publisher

<footer id="wb-info">
    <h2 class="wb-inv">About this site</h2>
<div class="gc-contextual">
        <div class="container">
            <nav>
                <h3>[Contextual footer header]</h3>
                <ul class="list-col-xs-1 list-col-sm-2 list-col-md-3"><li><a href="http://canada.ca/en">Contextual link 1</a></li><li><a href="http://canada.ca/en">Contextual link 2</a></li><li><a href="http://canada.ca/en">Contextual link 3</a></li></ul>
            </nav>
        </div>
    </div>

    <div class="gc-main-footer">
        <div class="container">
            <nav>
                <h3>Government of Canada</h3>
                <ul class="list-col-xs-1 list-col-sm-2 list-col-md-3"><li><a href="https://www.canada.ca/en/contact.html">All contacts</a></li>
                    <li><a href="https://www.canada.ca/en/government/dept.html">Departments and agencies</a></li>
                    <li><a href="https://www.canada.ca/en/government/system.html">About government</a></li></ul>
                <h4><span class="wb-inv">Themes and topics</span></h4>
                <ul class="list-unstyled colcount-sm-2 colcount-md-3"><li><a href="https://www.canada.ca/en/services/jobs.html">Jobs</a></li>
                    <li><a href="https://www.canada.ca/en/services/immigration-citizenship.html">Immigration and citizenship</a></li>
                    <li><a href="https://travel.gc.ca/">Travel and tourism</a></li>
                    <li><a href="https://www.canada.ca/en/services/business.html">Business</a></li>
                    <li><a href="https://www.canada.ca/en/services/benefits.html">Benefits</a></li>
                    <li><a href="https://www.canada.ca/en/services/health.html">Health</a></li>
                    <li><a href="https://www.canada.ca/en/services/taxes.html">Taxes</a></li>
                    <li><a href="https://www.canada.ca/en/services/environment.html">Environment and natural resources</a></li>
                    <li><a href="https://www.canada.ca/en/services/defence.html">National security and defence</a></li>
                    <li><a href="https://www.canada.ca/en/services/culture.html">Culture, history and sport</a></li>
                    <li><a href="https://www.canada.ca/en/services/policing.html">Policing, justice and emergencies</a></li>
                    <li><a href="https://www.canada.ca/en/services/transport.html">Transport and infrastructure</a></li>
                    <li><a href="https://international.gc.ca/world-monde/index.aspx?lang=eng">Canada and the world</a></li>
                    <li><a href="https://www.canada.ca/en/services/finance.html">Money and finance</a></li>
                    <li><a href="https://www.canada.ca/en/services/science.html">Science and innovation</a></li>
                    <li><a href="https://www.canada.ca/en/services/indigenous-peoples.html">Indigenous peoples</a></li>
                    <li><a href="https://www.canada.ca/en/services/veterans-military.html">Veterans and military</a></li>
                    <li><a href="https://www.canada.ca/en/services/youth.html">Youth</a></li></ul>
            </nav>
        </div>
    </div>

    <div class="gc-sub-footer">
        <div class="container d-flex align-items-center">
            <nav>
                <h3 class="wb-inv">Government of Canada Corporate</h3>
                <ul>
                    <li><a href="https://www.canada.ca/en/social.html">Social media</a></li>
                    <li><a href="https://www.canada.ca/en/mobile.html">Mobile applications</a></li>
                    <li><a href="https://www.canada.ca/en/government/about.html">About Canada.ca</a></li><li><a href="https://www.canada.ca/en/transparency/terms.html">Terms and conditions</a></li>
                    <li><a href="https://www.canada.ca/en/transparency/privacy.html">Privacy</a></li></ul>
            </nav>
            <div class="wtrmrk align-self-end">
                <img src="https://wet-boew.github.io/themes-dist/GCWeb/GCWeb/assets/wmms-blk.svg" alt="Symbol of the Government of Canada" />
            </div>
        </div>
    </div>
</footer>
shawnthompson commented 1 year ago

Contextual footer

Header: Digital Accessibility Toolkit

List of links:

Image

shawnthompson commented 1 year ago

@JulieBB23 @emmatseng-ux @oyinR

Can we get the French translations for the Contextual footer, please?

emmatseng-ux commented 1 year ago

Hey Shawn a few updates for the Github footer, from Melissa and Julie, here are the updated translations: "Code source (en anglais seulement)" "Discussions (en anglais seulement)" image

acev0010 commented 1 year ago

Hello, I'm Isabel and I'm updating the changes for the footer. Thank you for the update.

I'm only waiting for the French translation of the contextual footer when possible, please:

Contextual footer

Header: Digital Accessibility Toolkit

List of links:

Image

emmatseng-ux commented 1 year ago

Hey Isabel, I know you're working on the contextual footer but the Github footer will also need to be updated by someone on the team. Is this thread a suitable place to store that information?

As for the contextual footer, here is the translation. Thanks so much!

emmatseng-ux commented 1 year ago

@shawnthompson wanted to flag this question for you to see if you had a preference on where I updated the Github footer info. Let me know and I can move accordingly. Thanks!

acev0010 commented 1 year ago

Thank you for the translation. As for the GitHub Footer, I can take care of it. I will make a separate commit for it and wait for Shawn to decide if we want to keep it in the same pull request or separate. He is away for a few weeks so he might not answer right away, but I'll leave everything ready so we just need the approval to wrap this up.

emmatseng-ux commented 1 year ago

Amazing, thanks so much for your help Isabel! Let me know if there's anything else I can support you with.

acev0010 commented 1 year ago

You're welcome! I made two separate pull requests, one for the footer #324 and one for the GitHub footer #326

I would like to note that the GitHub footer doesn't look exactly like the screenshot you provided, since the ''(en anglais seulement)'' is in the same line as ''Code source'' instead of one on top of the other. I wasn't sure if it was due to a reflow issue so if you think it's a mistake then let me know in the pull request #326

shawnthompson commented 1 year ago

Hey Shawn a few updates for the Github footer, from Melissa and Julie, here are the updated translations: "Code source (en anglais seulement)" "Discussions (en anglais seulement)" image

I'll update this in my version: creates grid for contribute section by shawnthompson · Pull Request #308 · gc-da11yn/gc-da11yn.github.io for the contribute section of the footer.