gc-da11yn / gc-da11yn.github.io

Digital Accessibility Toolkit - Boîte à outils d'accessibilité numérique
https://a11y.canada.ca/en/
MIT License
31 stars 32 forks source link

[BUG] cleanHTML conflicts #509

Closed acev0010 closed 8 months ago

acev0010 commented 10 months ago

Describe the bug

To Reproduce Steps to reproduce the behaviour:

  1. Run npm: start in your terminal, make sure you are in the project's directory.
  2. Open a new terminal, if you're using VScode, it should be inside the "Terminal" tab on the top of the page.
  3. In the new terminal, runnpm run cleanHTML.
  4. Open your localhost link from the first terminal and navigate to the "page-list" page. The link should look something like this in your browser: http://localhost:8080/en/page-list/

Expected behaviour Page should be showing the numbers from the results, if you replicated the error correctly you will notice the numbers are missing. The search bar is also not working and the order of the links is disorganized. There might be more errors.

We think this is because the clean-html plugin is changing single quote (') to double quotes (") but we are using single quotes for the WET plugins.

Screenshot(s):

How it's supposed to look:

image

Description of image: Screenshot from the page-list page in which the search bar is working properly after typing "101" and it's showing "1 results out of 77" correctly.

How it looks:

image

Description of image: Screenshot from the page-list page in which the search is NOT working at all even after typing "101" and is still showing all the results. Additionally, the heading with the results only says "results out of"

Who shall do the work? [I will do it, I want to contribute] or [I am asking for someone else to please do the work]

Version of gc-da11yn you are using

latest

OS or Device: (e.g. iOS)

No response

Browser (e.g. Chrome, Safari)

Chrome

Version (e.g. 22)

No response

Additional context

No response