gc-da11yn / gc-da11yn.github.io

Digital Accessibility Toolkit - Boîte à outils d'accessibilité numérique
https://a11y.canada.ca/en/
MIT License
31 stars 32 forks source link

[CHANGE] New community to promote #583

Closed JulieBB23 closed 5 months ago

JulieBB23 commented 6 months ago

What page is the change request for? Please supply the URI.

https://a11y.canada.ca/en/community-directory/index.html

Approval needed?

Yes, I need to approve this request before change goes live

Yes, please send a request to the following person?

julie.belisleboutet@csps-efpc.gc.ca

Who shall do the work?

Timeline

ASAP

Additional context

Accessible Communications CoP Description BIL.docx Please add that description for the community, on the community page in both language.

shawnthompson commented 5 months ago

Do you think "GCpedia page" is good link text for this link?

Visit our GCpedia page for more information.

Would this be better?

Visit the Community of Practice on Accessible Communications page on GCPedia for more information.

JulieBB23 commented 5 months ago

Second option for sure.

From: Shawn Thompson @.> Sent: Tuesday, April 16, 2024 3:31 PM To: gc-da11yn/gc-da11yn.github.io @.> Cc: JulieBB @.>; Author @.> Subject: Re: [gc-da11yn/gc-da11yn.github.io] [CHANGE] New community to promote (Issue #583)

Do you think "GCpedia page" is good link text for this link?

Visit our GCpedia pagehttps://www.gcpedia.gc.ca/wiki/Communications_community_office_-_PLA#Community_of_Practice_on_Accessible_Communications for more information.

Would this be better?

Visit the Community of Practice on Accessible Communicationshttps://www.gcpedia.gc.ca/wiki/Communications_community_office_-_PLA#Community_of_Practice_on_Accessible_Communications page on GCPedia for more information.

— Reply to this email directly, view it on GitHubhttps://github.com/gc-da11yn/gc-da11yn.github.io/issues/583#issuecomment-2059789563, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASJPKBS2V24LBLOFL2SQZ43Y5V36TAVCNFSM6AAAAABFZITABCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZG44DSNJWGM. You are receiving this because you authored the thread.Message ID: @.**@.>>

shawnthompson commented 5 months ago

This breaks the expected look and behaviour of the other sections / links on the page:

The other blocks have heading with links and descriptions below them.

But this one has the link in the description and not the heading.

image

versus

image

This text is also very long compared to the other descriptions on the page.

image

shawnthompson commented 5 months ago

My suggestion is:

image

Remove the last paragraph and move link and internal icon to the heading to match the other links on this page.

shawnthompson commented 5 months ago

Ready for review:

In development - Community Directory - Digital Accessibility Toolkit