gc-proto / design-refresh

Prototypes, research and ideas related to Canada.ca visual design update
2 stars 1 forks source link

Known issues with the current grid system #16

Closed patlaj closed 6 years ago

patlaj commented 6 years ago

And how can we address them?

pcwsmith commented 6 years ago

examples of grids from other govs:

https://designsystem.digital.gov/components/grids/

https://design.cms.gov/layout/grid/

http://govuk-elements.herokuapp.com/layout/

https://www.ontario.ca/document/ontario-design-guide/layout

I think I got the number 12 from looking at the US examples before...

pcwsmith commented 6 years ago

moved to in progress.

  1. @jmealing showed us some of the weird alignments, she will provide more deets or screencaps here.

  2. this should be the focus of the grids aspect of this project - cleaning up the weirdness in alignments in the current grid system.

jmealing commented 6 years ago

weird-div-alignment

Example 1: Offices, By phone & International/non-residents are all set to "col-md-4" (x3 = 12 columns), yet they do not span the same distance as the main col-md-12 container leaving a big gap at the end.

jmealing commented 6 years ago

Weird alignments of boxes and weird gaps of whitespace:

https://open.canada.ca/en/apps?_ga=2.139234998.460502431.1529942523-1682205537.1529425950

bad-alignments

jmealing commented 6 years ago

Pockets of awkward white space and false floor:

https://www.canada.ca/en/agriculture-agri-food/corporate/lawrence-macaulay.html

false-floor

jmealing commented 6 years ago

More awkward gaps: https://www.canada.ca/en/services/benefits/ei.html https://www.canada.ca/en/public-health/topics/immunization-vaccines.html

awkward-gaps

jmealing commented 6 years ago

Whole page width text-heavy content...

https://www.canada.ca/en/revenue-agency/services/forms-publications/publications/gi-196/gst-hst-commercial-ride-sharing-services.html

12-col-walls-of-text

jmealing commented 6 years ago

Features easily mis-align:

https://www.canada.ca/en/services/health/healthy-living.html

mis-aligned-content

jmealing commented 6 years ago

Mobile navigation goes to the bottom in some templates:

https://www.canada.ca/en/employment-social-development/programs/ei/ei-list/ei-employers.html

disappearing-mobile-nav-2 disappearing-mobile-nav

jmealing commented 6 years ago

Minister layout: Paragraph length is long, huge white gap.

https://www.canada.ca/en/government/ministers/diane-lebouthillier.html

minister-layout

jmealing commented 6 years ago

Gaps, bad text width layout:

https://www.canada.ca/en/public-health/services/canadian-immunization-guide.html

just-no

jmealing commented 6 years ago

FIP gets pushed down by Language selector:

dedicated-row-pushes-fip

jmealing commented 6 years ago

Bad alignment in search:

bad-alignment-search

DK-TBS commented 6 years ago

The big gaps have been an awful problem for us for a long time - and they get so much worse when an author doesn't happen to need an element, and leaves out a sidebar block, or a photo or whatever. This is why I'm seriously thinking that we should look into trying to linearize the new design as much as possible. One rule: easy to follow: more important stuff goes above the less important stuff. Sidebars in only certain circumstances, etc - or better yet GONE. But I'm totally thinking off the top of my head here, I'm probably ignoring lots of considerations and loads of data :)