search

gcaa-org-tw / company-report-toolkit

協助工人、人工智慧，將企業永續報告書，轉為結構化資料 / A collection of toolkits to asist people & AI to transfrorm ESG report into mathcine readable data.
MIT License
1 stars 4 forks source link

add i18n capabilities, clean up install instructions, fix EOL in 404.vue #50

Open larshoeppner opened 1 year ago

larshoeppner commented 1 year ago

suggestion to add i18n for this project - this keeps the natural language content separate from the layout (DOM structure) and might increase the target audience

larshoeppner commented 1 year ago

@ddio not sure what your dev process is - I think it would be a good idea to add i18n since it has benefits even if translation isn't a main goal

let me know what you think

ddio commented 1 year ago

Thanks @larshoeppner ,

Appreciate the install instruction debug and suggestion about following latest LTS.

The only concern is i18n. As we are still in MVP phase, pages structure and copy will change rapidly. I would suggest we add i18n after MVP, which would be December this year.

If it also make sense to you, I would recommended to:

  1. Separate i18n into another MR
  2. Add recommended NPM & node version in README.md

Thanks for your advice & MR!

larshoeppner commented 1 year ago

@ddio I created a new PR (https://github.com/gcaa-org-tw/company-report-toolkit/pull/54) for setup related changes. I also added .vscode - if someone uses 4 spaces in their VS prefs, it will conflict with the project setup, so I think a workspace config is needed.

Re i18n, are you mostly concerned with the translation itself or the dependency? Personally I'd probably add the functionality now but defer the translation until the UI is stable.

ddio commented 1 year ago

For i18n, my concern are both due to we are in MVP phase. We can keep this one opened and come back on December, after GCAA finish pilot run on MVP.