search

gcacace / android-signaturepad

A custom Android View for drawing smooth signatures
Apache License 2.0
2.75k stars 638 forks source link

Why is android databinding enabled? #98

Open ghost opened 6 years ago

ghost commented 6 years ago

Does android-signaturepad need databinding? Because databinding is enabled in gradle file.

Wayn0 commented 6 years ago

I personally have not looked into it, only found repo a few days ago. But if you want to build with progaurd you will need.

-dontwarn android.databinding.** -keep class android.databinding.** { *; }

scottschmitz commented 6 years ago

Those proguard rules would be added by default in PR #106

voghDev commented 4 years ago

Yes it does, if you have a look at com.github.gcacace.signaturepad.utils.SignaturePadBindingAdapter, it uses various @BindingAdapter annotations. So I guess it is mandatory to include it.

I wonder if the library can run in an alternative way that gets rid of databinding