search

gcalmettes / reveal.js-d3

Full integration of animated javascript-based visualizations (D3, vega-lite, semiotic, etc ...) into Reveal.js presentations
https://gcalmettes.github.io/reveal.js-d3/demo/
MIT License
135 stars 31 forks source link

Config option to disable checking if file exists which could sometimes fail though file exists #10

Closed Pradhyo closed 6 years ago

Pradhyo commented 6 years ago

I was having issues loading external html file due to the doesFileExist() when I tried to open the main html file directly

      <section class="fig-container" data-file="index1.html">
      </section>

I was able to workaround this by always returning resolve(true) but what do you think about a config option to disable this function?

gcalmettes commented 6 years ago

Hi @Pradhyo, I added a new disableCheckFile option (see configuration options set to false by default.

Associated commit 2de2e9c6951971a004dcde90904a4d504afdbaef

Note that I also switched from xmlHttpRequest to the new fetch api for the doesFileExist function, in case the problem was coming from this.

Pradhyo commented 6 years ago

Thank you so much