gcamfer / Anomaly-ReactionRL

Using RL for anomaly detection in NSL-KDD
MIT License
113 stars 46 forks source link

Unable to execute code in Colab #26

Open shruthiswamyn opened 3 years ago

shruthiswamyn commented 3 years ago

Hi, I am trying to execute your codes under "A3C" folder. The files named estimators.py and A3CtypeAD.py are showing errors and demanding few code changes. Am I missing something? Kindly suggest.

Thanks in advance..

gcamfer commented 3 years ago

Hi, This code has not been updated for years, only the dependencies have been updated for security reasons. Maybe the error comes from the tensorflow updates that are no longer compatible, however I would not recommend using the old tensorflow because of its security problems, at least in industrial environments. In other case I can't help you more without output info. Regards!

shruthiswamyn commented 3 years ago

Hi,

Yes, I tried working with the older version of Tensorflow, The code did work. Thanks for your help. I shall definitely consider your recommendation to use the latest version of TF.

Regards, Shruthi

On Thu, Sep 30, 2021 at 12:55 PM Guillermo Caminero Fernández < @.***> wrote:

Hi, This code has not been updated for years, only the dependencies have been updated for security reasons. Maybe the error comes from the tensorflow updates that are no longer compatible, however I would not recommend using the old tensorflow because of its security problems, at least in industrial environments. In other case I can't help you more without output info. Regards!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gcamfer/Anomaly-ReactionRL/issues/26#issuecomment-930919085, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVYG6WVGGNVXIWOJOQT2PKDUEQGHBANCNFSM5ETIEF4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

gcamfer commented 3 years ago

Thanks for the info, Rigth now I have no time to solve this part. If you consider updating the parts that don't work, you can open a PR with the changes. 👍 Regards