Open m-bock opened 3 years ago
This is a great point - I would favor changing the prettier
config in the codebas (set the printWidth
to 80
), rather than forcing users to install another dependency. @gillchristian - thoughts?
Yeah, I think 80 is quite the default for columns :ok_hand:
True, maybe it's the best to just change that value for the docs generation as @IMax153 suggests. That makes sure the code looks good in Jekyll. Plus it leaves the user the choice which printWidth
to use in their codebase.
I assume that the prettier config in the code base is set to above 80 so that medium length type signatures don't look like a right mess.
Currently
docs-ts
uses prettier to format markdown before writing out the docs.The used options are:
The code blocks in Jekyll seem to work without horizontal scrolling only if lines don't exceed a 80 characters limit.
Is this intended behavior?
If not, I'd suggest one of those options:
Or, and this Is what I would suggest:
docs-ts
and encourage the user to use prettier-plugin-jsdoc. This is a much better editing experience. You have more control about the format, plus in the end the actual source file has the same formatting as the docs.What do you think?