search

gcanti / fp-ts-rxjs

fp-ts bindings for RxJS
https://gcanti.github.io/fp-ts-rxjs/
MIT License
187 stars 29 forks source link

Replace mergemap with switchmap #30

Open raveclassic opened 4 years ago

raveclassic commented 4 years ago

This PR replaces mergeMap with switchMap to avoid memory leaks.

contains parts of https://github.com/gcanti/fp-ts-rxjs/pull/29

closes #27

raveclassic commented 4 years ago

Ok, got it, I'll update the PR.

waynevanson commented 3 years ago

How did we go on this one? Switch map is important.

Otherwise I may have to maintain a patched version of this repo if I am to use chain in projects.

If there is anything pending for gcanti's proposal of changes, what are they? I'd be happy to lend a hand.

wmaurer commented 3 years ago

I know bumping github issues and PRs is bad form, but I also think switchMap really is important. chain is a core function, used by many other pipeable functions, and I'm finding it rather impractical to maintain my own versions so that I can have switchMap behaviour.

If nobody's willing to move this PR forward, should we create another simpler PR for the use of switchMap?

wmaurer commented 3 years ago

OK, let's see what happens, new PR here: https://github.com/gcanti/fp-ts-rxjs/pull/60