gcanti / fp-ts-rxjs

fp-ts bindings for RxJS
https://gcanti.github.io/fp-ts-rxjs/
MIT License
188 stars 29 forks source link

replace deprecated tslint #66

Open albohlabs opened 3 years ago

albohlabs commented 3 years ago

The project is currently pinned to rxjs 6 because rxjs 7 requires TS 4.2. The problem is that tslint-config-standard enforces TS 3.3

https://github.com/blakeembrey/tslint-config-standard/blob/6968884cb55070bffc3dacb9e6a147aecb639f84/package.json#L67

To get rid of the deprecated tslint and tslint-config-standard packages we can replace it by eslint-config-standard-with-typescript which is based on the eslint-config-standard and suggested in https://github.com/blakeembrey/tslint-config-standard/issues/61

An ESLint shareable config for TypeScript that is based on eslint-config-standard and has TypeScript specific rules from @typescript-eslint/eslint-plugin.

First step to solve #63

albohlabs commented 3 years ago

TODO:

mlegenhausen commented 3 years ago

The project is currently pinned to rxjs 6 because rxjs 7 requires TS 4.2. The problem is that tslint-config-standard enforces TS 3.3

This is just a dev dependency and does not enforce a certain TypeScript version on the fp-ts-rxjs project. If you want to add support rxjs 7 you should be able to update typescript without any problems.

albohlabs commented 3 years ago

Hm, maybe i misunderstand something here…

When i try to update the TS version to match the required version of rxjs npm throws the following error message

$ npm install --save-dev typescript@4.3.5
....
npm ERR! Could not resolve dependency:
npm ERR! peer typescript@"^2.2.0 || ^3.0.0" from tslint-eslint-rules@5.4.0
npm ERR! node_modules/tslint-eslint-rules
npm ERR!   tslint-eslint-rules@"^5.3.1" from tslint-config-standard@8.0.1
npm ERR!   node_modules/tslint-config-standard
npm ERR!     dev tslint-config-standard@"^8.0.1" from the root project

But with rxjs 7 and without TS >=4.2 this project can't be build

$ tsc -p ./tsconfig.build.json && tsc -p ./tsconfig.build-es6.json && npm run import-path-rewrite && ts-node scripts/build
…
Found 58 errors.
bravely commented 2 years ago

@mlegenhausen After giving it a shot, @albohlabs has the right of it. Far as I can tell this does seem like a hard block to upgrading to rxjs 7.

wnadurski commented 2 years ago

Hi, thanks for this PR :) Are you able to merge it?

dilame commented 1 year ago

Hello! I would also like to integrate fp-ts and rxjs, but i am using rxjs@7. So i am voting for merging it:)

JalilArfaoui commented 1 year ago

I need this too ! Is there any blocker ? This PR seems to be ready for a year now …