search

gcanti / money-ts

TypeScript library for type-safe and lossless encoding and manipulation of world currencies and precious metals
https://gcanti.github.io/money-ts/
MIT License
90 stars 8 forks source link

add io-ts types #1

Closed gcanti closed 6 years ago

gcanti commented 6 years ago

@sledorze There's a bunch of types here that we could move to io-ts-types, what do you think? (if you are interested in this library of course)

sledorze commented 6 years ago

@gcanti I'm not sure about the implementation of Integer (relying on bounded 'number' looks brittle and limited to me). Beside that, yes some types are interesting

gcanti commented 6 years ago

relying on bounded 'number' looks brittle and limited to me

@sledorze what you mean?

sledorze commented 6 years ago

@gcanti number can overflow and has limited precision.

gcanti commented 6 years ago

Ah right, I'm looking for some big* implementations. These are the best candidates so far

By chance do you know any better implementation?

sledorze commented 6 years ago

@gcanti we're using big-integer ourselves, we've however not spent too much time looking around for an alternative.

gcanti commented 6 years ago

@sledorze master is now based on big-integer, let me know what you think about the current implementation