gcanti / newtype-ts

Implementation of newtypes in TypeScript
https://gcanti.github.io/newtype-ts/
MIT License
582 stars 14 forks source link

chore: update fp-ts to 0.5.4 #3

Closed leemhenson closed 7 years ago

leemhenson commented 7 years ago

Hi Giulio

I made the mistake of updating some of our projects to fp-ts 0.5.4, and now I'm getting the dreaded "objects have the same name but are different" TS errors. This is because I'm using other libs of yours like this one, so npm is loading two copies of fp-ts. Any chance you can cut a new version that ups the dependency to 0.5.4?

I'll submit PRs for the others too.

gcanti commented 7 years ago

Weird, "fp-ts": "^0.5.1" means you should get the latest version. Have you tried a clean install?

gcanti commented 7 years ago

After a clean install in my test project I can see this

giulio@mbp test $ npm list fp-ts
test@1.0.0 /Users/giulio/Documents/Projects/typescript/test
├── fp-ts@0.5.4 
├─┬ fp-ts-fluture@0.1.0
│ └── fp-ts@0.5.4  deduped
├─┬ fp-ts-routing@0.0.1
│ └── fp-ts@0.5.4  deduped
├─┬ io-ts@0.7.1
│ └── fp-ts@0.5.4  deduped
├─┬ io-ts-types@0.0.2
│ └── fp-ts@0.5.4  deduped
├─┬ monocle-ts@0.4.2
│ └── fp-ts@0.5.4  deduped
└─┬ newtype-ts@0.0.1
  └── fp-ts@0.5.4  deduped

so everything should work as it is

leemhenson commented 7 years ago

Well I'll be a sea-monkeys uncle. Nuking everything and reinstalling clean did dedupe it as you say.

Move along, nothing to see here. 😅