search

gcanti / tcomb-form

Forms library for react
https://gcanti.github.io/tcomb-form
MIT License
1.16k stars 136 forks source link

Add TypeScript definitions for tcomb-form #394

Open RedRoserade opened 6 years ago

RedRoserade commented 6 years ago

This adds TypeScript definitions for tcomb-form, based on the Guide.

A devDependency on @types/react was added for the Form component and the other Component classes.

Similar to the type definition for tcomb-validation, https://github.com/gcanti/tcomb-validation/pull/63, this extends the tcomb module, adding getTcombFormFactory and getTcombFormOptions to t.Type<T>.

I am, however, not sure if the type definitions are 100% complete or accurate. I'd appreciate your feedback to improve them.

gcanti commented 6 years ago

@RedRoserade this is great, thanks for taking the time to write this definitions

bialasik commented 6 years ago

Why it's still doesn't merged?

gcanti commented 6 years ago

My bad, there was a pending review which I didn't submit at the time, sorry @RedRoserade

marcodafonseca commented 4 years ago

Can the above change request please be acted on? It would be really helpful to have Typescript definitions enabled.