search

gcanti / uvdom

Universal Virtual DOM
MIT License
53 stars 0 forks source link

Revise recent `react` dependency moving from peerDependencies to dependencies in package.json #4

Open dearlordylord opened 8 years ago

dearlordylord commented 8 years ago

Hey @gcanti,

I currently debugging issue with tcomb-form in my project that popped out after update to React 0.14.3 and consequently to latest tcomb-form / uvdom. It keeps giving me two React copies loaded related error exactly on forms rendering. I wondering if moving react to dependencies had something to do with it. Checked what people says about it in Internet and it seems that they discourage placing it under dependencies. Maybe you have some insight?

Thanks, Igor

gcanti commented 8 years ago

Hi @Firfi, Uhm.. I didn't notice any problem so far (this dependencies, peerDependencies thing kills me :)

My current configuration

node --version
v0.12.2
npm --version
2.9.0

example of a package.json of mine https://github.com/gcanti/tcomb-spa-example/blob/master/package.json

Could you post your configuration / package.json?

dearlordylord commented 8 years ago

Hey @gcanti, unfortunately I can't show you or look myself at package.json as I have to use special 'simplified' handler package (for Meteor.js application). However it what I know is that it uses Browserify instead of Webpack. I found solution for my issue defining global vendor-provided (not npm-installed!) React and ReactDOM through browserify's exposify package. It's still a riddle for me why didn't it worked with just npm but as I said I didn't got lot of debugging info from used package.